Re: [v2] powerpc/sstep.c - Fix emulation fall-through
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-05-10 21:48:46
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-05-10 21:48:46
On Tue, 2016-16-02 at 06:31:53 UTC, Oliver O'Halloran wrote:
There is a switch fallthough in instr_analyze() which can cause an invalid instruction to be emulated as a different, valid, instruction. The rld* (opcode 30) case extracts a sub-opcode from bits 3:1 of the instruction word. However, the only valid values of this field a 001 and 000. These cases are correctly handled, but the others are not which causes execution to fall through into case 31. Breaking out of the switch causes the instruction to be marked as unknown and allows the caller to deal with the invalid instruction in a manner consistent with other invalid instructions. Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/ab66c8ca52f790d816e421d3b1 cheers