Thread (4 messages) flat view 4 messages, 2 authors, 2016-05-04

Re: [PATCH] selftests/powerpc: Fix subpage_prot test to return !0 on failure

From: Aneesh Kumar K.V <hidden>
Date: 2016-05-02 11:18:12

Michael Ellerman [off-list ref] writes:
It's helpful for automated testing if the test returns error codes back
to the calling program.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Reviewed-by: Aneesh Kumar K.V <redacted>
quoted hunk ↗ jump to hunk
---
 tools/testing/selftests/powerpc/mm/subpage_prot.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/powerpc/mm/subpage_prot.c b/tools/testing/selftests/powerpc/mm/subpage_prot.c
index 440180ff8089..7ccdc96b977d 100644
--- a/tools/testing/selftests/powerpc/mm/subpage_prot.c
+++ b/tools/testing/selftests/powerpc/mm/subpage_prot.c
@@ -207,14 +207,16 @@ int test_file(void)

 int main(int argc, char *argv[])
 {
-	test_harness(test_anon, "subpage_prot_anon");
+	int rc;
+
+	rc = test_harness(test_anon, "subpage_prot_anon");
+	if (rc)
+		return rc;

 	if (argc > 1)
 		file_name = argv[1];
 	else
 		file_name = "tempfile";

-	test_harness(test_file, "subpage_prot_file");
-
-	return 0;
+	return test_harness(test_file, "subpage_prot_file");
 }
-- 
2.5.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help