Thread (40 messages) 40 messages, 7 authors, 2017-04-03

RE: [v10, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

From: Yangbo Lu <yangbo.lu@nxp.com>
Date: 2016-05-05 09:41:55
Also in: linux-arm-kernel, linux-clk, linux-devicetree, linux-i2c, linux-iommu, linux-mmc, lkml, netdev

Hi Arnd,

-----Original Message-----
From: Arnd Bergmann [mailto:arnd@arndb.de]
Sent: Thursday, May 05, 2016 4:32 PM
To: linuxppc-dev@lists.ozlabs.org
Cc: Yangbo Lu; linux-mmc@vger.kernel.org; devicetree@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
linux-clk@vger.kernel.org; linux-i2c@vger.kernel.org; iommu@lists.linux-
foundation.org; netdev@vger.kernel.org; Mark Rutland;
ulf.hansson@linaro.org; Russell King; Bhupesh Sharma; Joerg Roedel;
Santosh Shilimkar; Yang-Leo Li; Scott Wood; Rob Herring; Claudiu Manoil;
Kumar Gala; Xiaobo Xie; Qiang Zhao
Subject: Re: [v10, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-
R1.0-R2.0
=20
On Thursday 05 May 2016 11:12:30 Yangbo Lu wrote:
quoted
+       fsl_guts_init();
+       svr =3D fsl_guts_get_svr();
+       if (svr) {
+               esdhc->soc_ver =3D SVR_SOC_VER(svr);
+               esdhc->soc_rev =3D SVR_REV(svr);
+       } else {
+               dev_err(&pdev->dev, "Failed to get SVR value!\n");
+       }
+
=20
=20
Sorry for jumping in again after not participating in the discussion for
the past few versions.
=20
What happened to my suggestion of making this a platform-independent
interface to avoid the link time dependency?
=20
Specifically, why not add an exported function to drivers/base/soc.c that
uses glob_match() for comparing a string in the device driver to the ID
of the SoC that is set by whatever SoC identifying driver the platform
has?
=20
	Arnd
[Lu Yangbo-B47093] I think this has been discussed in v6.
You can find Scott's comments about this in below link.
https://patchwork.kernel.org/patch/8544501/

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help