Hi Arnd,

On Thu, Apr 28, 2016 at 9:48 AM, Geert Uytterhoeven
[off-list ref] wrote:

On Thu, Apr 28, 2016 at 12:34 AM, Arnd Bergmann [off-list ref] wrote:

quoted

I ended up stuffing the two patch series into one, as they are now
more dependent on one another. This now thoroughly removes the
genrtc driver including the asm/rtc.h headers it uses. For all
architectures that still have a meaningful asm/rtc.h, this goes
through two stages:

1) make the rtc-generic implementation independent of asm/rtc.h
2) remove the asm/rtc.h header and disallow the gen_rtc driver

As the last step, the driver itself gets removed.

In general, after fixing the minor nit:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

For the m68k bits:
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>

More build coverage uncovered two build failures on m68k due to "[PATCH v3
02/16] rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h":

bvme6000_defconfig:

    In file included from arch/m68k/bvme6000/rtc.c:19:
    include/linux/mc146818rtc.h: In function =E2=80=98mc146818_is_updating=
=E2=80=99:
    include/linux/mc146818rtc.h:138: error: implicit declaration of
function =E2=80=98CMOS_READ=E2=80=99
    include/linux/mc146818rtc.h: In function =E2=80=98mc146818_get_time=E2=
=80=99:
    include/linux/mc146818rtc.h:189: error: =E2=80=98RTC_ALWAYS_BCD=E2=80=
=99
undeclared (first use in this function)
    include/linux/mc146818rtc.h:189: error: (Each undeclared
identifier is reported only once
    include/linux/mc146818rtc.h:189: error: for each function it appears in=
.)
    include/linux/mc146818rtc.h: In function =E2=80=98mc146818_set_time=E2=
=80=99:
    include/linux/mc146818rtc.h:279: error: =E2=80=98RTC_ALWAYS_BCD=E2=80=
=99
undeclared (first use in this function)
    include/linux/mc146818rtc.h:290: error: implicit declaration of
function =E2=80=98CMOS_WRITE=E2=80=99

mvme16x_defconfig:

    In file included from arch/m68k/mvme16x/rtc.c:18:
    include/linux/mc146818rtc.h: In function =E2=80=98mc146818_is_updating=
=E2=80=99:
    include/linux/mc146818rtc.h:138: error: implicit declaration of
function =E2=80=98CMOS_READ=E2=80=99
    include/linux/mc146818rtc.h: In function =E2=80=98mc146818_get_time=E2=
=80=99:
    include/linux/mc146818rtc.h:189: error: =E2=80=98RTC_ALWAYS_BCD=E2=80=
=99
undeclared (first use in this function)
    include/linux/mc146818rtc.h:189: error: (Each undeclared
identifier is reported only once
    include/linux/mc146818rtc.h:189: error: for each function it appears in=
.)
    include/linux/mc146818rtc.h: In function =E2=80=98mc146818_set_time=E2=
=80=99:
    include/linux/mc146818rtc.h:279: error: =E2=80=98RTC_ALWAYS_BCD=E2=80=
=99
undeclared (first use in this function)
    include/linux/mc146818rtc.h:290: error: implicit declaration of
function =E2=80=98CMOS_WRITE=E2=80=99

These do not show up with a multi-platform config including Atari
support, as arch/m68k/include/asm/mc146818rtc.h provides a definition of
CMOS_READ() if CONFIG_ATARI=3Dy.

Fortunately the fixes are simple: replace <linux/mc146818rtc.h> by
<linux/rtc.h>. Will send patches to fix...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds