Re: [PATCH V2 55/68] powerpc/mm: VMALLOC abstraction

From
Aneesh Kumar K.V <hidden>
Date
2016-04-23 08:40:49
Reply to
Michael Neuling, 2016-04-22
Michael Neuling [off-list ref] writes:
Aneesh,

I'm not sure why we need this patch.

It seems to be moving the initialisation of some global variables into
init functions from the definitions.  And renames some things.

because the value to which it is getting initialized is no more a
constant.
quoted
diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c
index 41503d7d53a1..3759df52bd67 100644
--- a/arch/powerpc/kernel/pci_64.c
+++ b/arch/powerpc/kernel/pci_64.c
@@ -38,7 +38,7 @@
  * ISA drivers use hard coded offsets.  If no ISA bus exists nothing
  * is mapped on the first 64K of IO space
  */
-unsigned long pci_io_base = ISA_IO_BASE;
+unsigned long pci_io_base;
 EXPORT_SYMBOL(pci_io_base);
 
 static int __init pcibios_init(void)
@@ -47,6 +47,7 @@ static int __init pcibios_init(void)
 
 	printk(KERN_INFO "PCI: Probing PCI hardware\n");
 
+	pci_io_base = ISA_IO_BASE;
Did you mean to change this in this patch?  This seems to be a random
change in pci code.
ISA_IO_BASE is not a constant now.

-aneesh
Thread (139 messages) 139 messages, 9 authors, last reply 2016-11-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help