RE: [PATCH 5/5] dmaengine: fsldma: Use dma_pool_zalloc
From: Yang-Leo Li <hidden>
Date: 2016-04-29 21:02:33
Also in:
kernel-janitors, lkml
-----Original Message----- From: Julia Lawall [mailto:Julia.Lawall@lip6.fr] Sent: Friday, April 29, 2016 3:09 PM To: Li Yang <redacted> Cc: kernel-janitors@vger.kernel.org; Zhang Wei <zw@zh-kernel.org>; Vinod Koul [off-list ref]; Dan Williams [off-list ref]; linuxppc-dev@lists.ozlabs.org; dmaengine@vger.kernel.org; linux- kernel@vger.kernel.org Subject: [PATCH 5/5] dmaengine: fsldma: Use dma_pool_zalloc =20 Dma_pool_zalloc combines dma_pool_alloc and memset 0. The semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/=
)
=20
// <smpl>
@@
expression d,e;
statement S;
@@
=20
d =3D
- dma_pool_alloc
+ dma_pool_zalloc
(...);
if (!d) S
- memset(d, 0, sizeof(*d));
// </smpl>
=20
Signed-off-by: Julia Lawall <redacted>Acked-by: Li Yang <redacted>
quoted hunk ↗ jump to hunk
=20 --- drivers/dma/fsldma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) =20diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c indexaac85c3..a8828ed 100644--- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c@@ -462,13 +462,12 @@ static struct fsl_desc_sw*fsl_dma_alloc_descriptor(struct fsldma_chan *chan) struct fsl_desc_sw *desc; dma_addr_t pdesc; =20 - desc =3D dma_pool_alloc(chan->desc_pool, GFP_ATOMIC, &pdesc); + desc =3D dma_pool_zalloc(chan->desc_pool, GFP_ATOMIC, &pdesc); if (!desc) { chan_dbg(chan, "out of memory for link descriptor\n"); return NULL; } =20 - memset(desc, 0, sizeof(*desc)); INIT_LIST_HEAD(&desc->tx_list); dma_async_tx_descriptor_init(&desc->async_tx, &chan->common); desc->async_tx.tx_submit =3D fsl_dma_tx_submit;