Thread (32 messages) 32 messages, 5 authors, 2017-04-28

Re: [PATCH v5 2/4] printk/nmi: warn when some message has been lost in NMI context

From: Russell King - ARM Linux <hidden>
Date: 2016-04-27 09:35:06
Also in: linux-arm-kernel, linux-mips, linux-sh, lkml, sparclinux

On Thu, Apr 21, 2016 at 01:48:43PM +0200, Petr Mladek wrote:
quoted hunk ↗ jump to hunk
@@ -64,8 +65,10 @@ static int vprintk_nmi(const char *fmt, va_list args)
 again:
 	len = atomic_read(&s->len);
 
-	if (len >= sizeof(s->buffer))
+	if (len >= sizeof(s->buffer)) {
+		atomic_inc(&nmi_message_lost);
This should be fine - I think its reasonable to expect that no one is
using a spinlock implementation for their atomic ops for this...

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help