Re: [PATCH] powerpc: ppc4xx: drop unused variable
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2016-03-31 10:09:50
Also in:
linux-gpio
On Thu, 2016-03-31 at 09:14 +0200, Linus Walleij wrote:
commit 0d36fe65f58391712e11a6621075f373216e5f00
"powerpc: ppc4xx: use gpiochip data pointer"
made the mm_gc local variable in ppc4xx_gpio_set()
redundant, and when GCC treats warnings as errors this
happens:
arch/powerpc/sysdev/ppc4xx_gpio.c: In function 'ppc4xx_gpio_set':
arch/powerpc/sysdev/ppc4xx_gpio.c:93:26: error:
unused variable 'mm_gc' [-Werror=unused-variable]
struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
^
cc1: all warnings being treated as errors
Reported-by: kbuild test robot <redacted>
Cc: Anatolij Gustschin <agust@denx.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <redacted>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Linus Walleij <redacted>
---
I've applied this to the GPIO tree where the offending
commit is now merged.Thanks. If you feel like cross building powerpc in future it should be as simple as: $ dnf install gcc-powerpc64-linux-gnu || apt-get install gcc-powerpc-linux-gnu $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- ... :) cheers