Re: [PATCH 6/7] cxlflash: Fix to avoid unnecessary scan with internal LUNs

On Mar 4, 2016, at 3:55 PM, Uma Krishnan [off-list ref] =

wrote:

=20
From: "Manoj N. Kumar" <redacted>
=20
When switching to the internal LUN defined on the
IBM CXL flash adapter, there is an unnecessary
scan occurring on the second port. This scan leads
to the following extra lines in the log:
=20
Dec 17 10:09:00 tul83p1 kernel: [ 3708.561134] cxlflash 0008:00:00.0: =

cxlflash_queuecommand: (scp=3Dc0000000fc1f0f00) 11/1/0/0 =
cdb=3D(A0000000-00000000-10000000-00000000)

Dec 17 10:09:00 tul83p1 kernel: [ 3708.561147] process_cmd_err: cmd =

failed afu_rc=3D32 scsi_rc=3D0 fc_rc=3D0 afu_extra=3D0xE, =
scsi_extra=3D0x0, fc_extra=3D0x0

=20
By definition, both of the internal LUNs are on the first =

port/channel.

=20
When the lun_mode is switched to internal LUN the
same value for host->max_channel is retained. This
causes an unnecessary scan over the second port/channel.
=20
This fix alters the host->max_channel to 0 (1 port), if internal
LUNs are configured and switches it back to 1 (2 ports) while
going back to external LUNs.
=20
Signed-off-by: Manoj N. Kumar <redacted>

Acked-by: Matthew R. Ochs <redacted>