Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings

On Tue, 2016-03-08 at 01:16 +0000, Qiang Zhao wrote:

On Tue, Mar 08, 2016 at 1:28AM, Scott Wood wrote:

quoted

-----Original Message-----
From: Scott Wood [mailto:oss@buserror.net]
Sent: Tuesday, March 08, 2016 1:28 AM
To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
Cc: Yang-Leo Li <redacted>; Xiaobo Xie <redacted>;
linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-
dev@lists.ozlabs.org
Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings

On Mon, 2016-03-07 at 02:35 +0000, Qiang Zhao wrote:

quoted

On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote:

quoted

-----Original Message-----
From: Rob Herring [mailto:robh@kernel.org]
Sent: Saturday, March 05, 2016 12:26 PM
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: oss@buserror.net; Yang-Leo Li <redacted>; Xiaobo Xie
[off-list ref]; linux-kernel@vger.kernel.org;
devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings

On Tue, Mar 01, 2016 at 03:09:39PM +0800, Zhao Qiang wrote:

quoted

Add uqe_serial document to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
t

Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
	- modify tx/rx-clock-name specification Changes for v2
	- NA

 .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt        | 19

+++++++++++++++++++

quoted

 1 file changed, 19 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx
t

diff --git
a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
txt
b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
txt
new file mode 100644
index 0000000..436c71c

--- /dev/null
+++

b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.

quoted

quoted

quoted

+++ txt

@@ -0,0 +1,19 @@
+* Serial
+
+Currently defined compatibles:
+- ucc_uart

I guess this is in use already and okay. However, looking at the
driver there really should be SoC specific compatible strings here
since the driver is looking up the SoC compatible string and
composing the firmware filename from that.

Ok, I will changed both driver and this compatible.

But don't break existing device trees while doing so.

Do I need to send driver patch in this patchset or a individual patch?

Doesn't matter.

-Scott