Thread (3 messages) flat view 3 messages, 2 authors, 2016-02-17

RE: linux-4.5-rc4/arch/powerpc/boot/treeboot-akebono.c:90: possible bad test ?

From: David Binderman <hidden>
Date: 2016-02-17 07:39:44

Hello there Daniel=2C=0A=
=0A=
----------------------------------------=0A=
That looks like a good suggestion: maybe make the test 'if (!emac)'=0A=
rather than explicitly comparing with zero.=0A=
=0A=
Righto.=0A=
=0A=
Are you comfortable sending a patch to that effect?=0A=
=0A=
Sorry=2C no. =0A=
=0A=
My email provider can't implement the somewhat strict whitespace=0A=
rules of kernel patches.=0A=
=0A=
Nothing stopping any keen person implementing that patch=2C however =3B->=
=0A=
=0A=
I checked the rest of the treeboot-akebono.c source code file with=0A=
the static analyser and found nothing wrong. No warnings from=0A=
gcc -Wextra=2C either=2C so after the patch=2C it looks ok to me.=0A=
=0A=
=0A=
Regards=0A=
=0A=
David Binderman=0A=
=0A=
 		 	   		  =
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help