Re: [RFC, kernel] powerpc/ioda: Set "read" permission when "write" is set

From
Michael Ellerman <mpe@ellerman.id.au>
Date
2016-02-16 03:18:25
Reply to
Alexey Kardashevskiy, 2016-01-12
On Tue, 2016-12-01 at 04:40:20 UTC, Alexey Kardashevskiy wrote:
Quite often drivers set only "write" permission assuming that this
includes "read" permission as well and this works on plenty platforms.
However IODA2 is strict about this and produces an EEH when "read"
permission is not and reading happens.

This adds a workaround in IODA code to always add the "read" bit when
the "write" bit is set.

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Alexey Kardashevskiy <redacted>
Tested-by: Douglas Miller <redacted>
Are you planning on sending a non-RFC version of this?

If so is it an urgent fix I should send upstream now? And if so should it
also be CC'ed to stable?

cheers
Thread (12 messages) 12 messages, 4 authors, last reply 2016-02-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help