Re: [PATCH] mtd/ifc: Add support for IFC controller version 2.0

On Fri, 2016-02-12 at 11:44 -0800, Brian Norris wrote:

On Thu, Feb 04, 2016 at 05:07:16PM -0600, Li Yang wrote:

quoted

On Wed, Feb 3, 2016 at 12:36 AM, Raghav Dogra [off-list ref]
wrote:

quoted

The new IFC controller version 2.0 has a different memory map page.
Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
This patch segregates the IFC global and runtime registers to
appropriate
PAGE sizes.

If the global registers and the runtime registers are so independent
that they have to be on different page boundaries, it would make more
sense for them to be defined as separate reg regions in the device
tree at the very beginning.  Then we would only need to change the
device tree now and it would be future proof for any page size.

To be clear: Scott, you were NACK'ing the DT binding change request,
right? I though we had an Ack on the previous revision (that Raghav
failed to carry).

Yes.  The patch is OK, the DT binding change (which is not in the patch) is
not.

-Scott