Re: [PATCH v2 3/7] QE: Add uqe_serial document to bindings
From: Scott Wood <oss@buserror.net>
Date: 2016-02-23 20:27:18
Also in:
linux-devicetree, lkml
On Tue, 2016-02-23 at 14:23 -0600, Rob Herring wrote:
On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote:quoted
Add uqe_serial document to Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> --- Changes for v2 - modify tx/rx-clock-name specification .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt new file mode 100644 index 0000000..436c71c--- /dev/null +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt@@ -0,0 +1,19 @@ +* Serial + +Currently defined compatibles: +- ucc_uart + +Properties for ucc_uart: +port-number : port number of UCC-UARTHow is this used?quoted
+tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source, + should be "clk1"-"clk28" for external clock source.Perhaps you should be using the clock binding here and in other bindings?
These properties are required by the underlying UCC binding (Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt) and predate the clock binding. -Scott