Add IC, SI and SIRAM document of QE to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- Add interrupt-controller in Required properties
- delete address-cells and size-cells for qe-si and qe-siram
.../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++
1 file changed, 50 insertions(+)
@@ -69,6 +69,56 @@ Example: }; };+* Interrupt Controller (IC)++Required properties:+- compatible : should be "fsl,qe-ic".+- reg : Address range of IC register set.+- interrupts : interrupts generated by the device.+- interrupt-controller : this device is a interrupt controller.++Example:++ qeic: interrupt-controller@80 {+ interrupt-controller;+ compatible = "fsl,qe-ic";+ #address-cells = <0>;+ #interrupt-cells = <1>;+ reg = <0x80 0x80>;+ interrupts = <95 2 0 0 94 2 0 0>; //high:79 low:78+ };++* Serial Interface Block (SI)++The SI manages the routing of eight TDM lines to the QE block serial drivers+, the MCC and the UCCs, for receive and transmit.++Required properties:+- compatible : should be "fsl,qe-si".+- reg : Address range of SI register set.++Example:++ si1: si@700 {+ compatible = "fsl,qe-si";+ reg = <0x700 0x80>;+ };++* Serial Interface Block RAM(SIRAM)++store the routing entries of SI++Required properties:+- compatible : should be "fsl,qe-siram".+- reg : Address range of SI RAM.++Example:++ siram1: siram@1000 {+ compatible = "fsl,qe-siram";+ reg = <0x1000 0x800>;+ };+ * QE Firmware Node This node defines a firmware binary that is embedded in the device tree, for
Add ucc hdlc document to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- use ucc-hdlc instead of ucc_hdlc
- add more information to properties.
.../bindings/powerpc/fsl/cpm_qe/network.txt | 93 ++++++++++++++++++++++
1 file changed, 93 insertions(+)
@@ -41,3 +41,96 @@ Example: fsl,mdio-pin = <12>; fsl,mdc-pin = <13>; };++* HDLC++Currently defined compatibles:+- fsl,ucc-hdlc++Properties for fsl,ucc-hdlc:+- rx-clock-name+- tx-clock-name+ Usage: required+ Value type: <string>+ Definition : should be "brg1"-"brg16" for internal clock source,+ should be "clk1"-"clk28" for external clock source.++- fsl,rx-sync-clock+ Usage: required+ Value type: <string>+ Definition : should be "none" when using internal clock source,+ should be "rsync_pin" when using external clock source.++- fsl,tx-sync-clock+ Usage: required+ Value type: <string>+ Definition : should be "none" when using internal clock source,+ should be "tsync_pin" when using external clock source.++- fsl,tx-timeslot+- fsl,rx-timeslot+ Usage: required+ Value type: <u32>+ Definition : time slot for TDM operation. Indicates which time slots+ used for transmitting and receiving.++- fsl,tdm-framer-type+ Usage: required+ Value type: <string>+ Definition : "e1" or "t1"++- fsl,tdm-mode+ Usage: required+ Value type: <string>+ Definition : "normal" or "internal-loopback"++- fsl,tdm-id+ Usage: required+ Value type: <u32>+ Definition : number of TDM ID++- fsl,siram-entry-id+ Usage: required+ Value type: <u32>+ Definition : should be 0,2,4...64. the number of TDM entry.++- fsl,tdm-interface+ Usage: optional+ Value type: <empty>+ Definition : Specify that hdlc is based on tdm-interface++Example:++ ucc@2000 {+ compatible = "fsl,ucc-hdlc";+ rx-clock-name = "clk8";+ tx-clock-name = "clk9";+ fsl,rx-sync-clock = "rsync_pin";+ fsl,tx-sync-clock = "tsync_pin";+ fsl,tx-timeslot = <0xfffffffe>;+ fsl,rx-timeslot = <0xfffffffe>;+ fsl,tdm-framer-type = "e1";+ fsl,tdm-mode = "normal";+ fsl,tdm-id = <0>;+ fsl,siram-entry-id = <0>;+ fsl,tdm-interface;+ };+fsl,siram-entry-id : SI RAM entry ID for the TDM+fsl,tdm-interface : hdlc is based on tdm-interface++Example:++ ucc@2000 {+ compatible = "fsl,ucc-hdlc";+ rx-clock-name = "clk8";+ tx-clock-name = "clk9";+ fsl,rx-sync-clock = "rsync_pin";+ fsl,tx-sync-clock = "tsync_pin";+ fsl,tx-timeslot = <0xfffffffe>;+ fsl,rx-timeslot = <0xfffffffe>;+ fsl,tdm-framer-type = "e1";+ fsl,tdm-mode = "normal";+ fsl,tdm-id = <0>;+ fsl,siram-entry-id = <0>;+ fsl,tdm-interface;+ };
From: Rob Herring <robh@kernel.org> Date: 2016-02-23 20:21:57
On Thu, Feb 18, 2016 at 09:06:07AM +0800, Zhao Qiang wrote:
Add ucc hdlc document to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
Not a very useful description.
quoted hunk
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- use ucc-hdlc instead of ucc_hdlc
- add more information to properties.
.../bindings/powerpc/fsl/cpm_qe/network.txt | 93 ++++++++++++++++++++++
1 file changed, 93 insertions(+)
@@ -41,3 +41,96 @@ Example: fsl,mdio-pin = <12>; fsl,mdc-pin = <13>; };++* HDLC++Currently defined compatibles:+- fsl,ucc-hdlc++Properties for fsl,ucc-hdlc:+- rx-clock-name+- tx-clock-name+ Usage: required+ Value type: <string>+ Definition : should be "brg1"-"brg16" for internal clock source,+ should be "clk1"-"clk28" for external clock source.++- fsl,rx-sync-clock+ Usage: required+ Value type: <string>+ Definition : should be "none" when using internal clock source,+ should be "rsync_pin" when using external clock source.
Why not a boolean property here?
+
+- fsl,tx-sync-clock
+ Usage: required
+ Value type: <string>
+ Definition : should be "none" when using internal clock source,
+ should be "tsync_pin" when using external clock source.
And here.
+
+- fsl,tx-timeslot
+- fsl,rx-timeslot
Perhaps append "-mask"
+ Usage: required
+ Value type: <u32>
+ Definition : time slot for TDM operation. Indicates which time slots
+ used for transmitting and receiving.
+
+- fsl,tdm-framer-type
+ Usage: required
+ Value type: <string>
+ Definition : "e1" or "t1"
Boolean?
+
+- fsl,tdm-mode
+ Usage: required
+ Value type: <string>
+ Definition : "normal" or "internal-loopback"
Boolean?
+
+- fsl,tdm-id
+ Usage: required
+ Value type: <u32>
+ Definition : number of TDM ID
+
+- fsl,siram-entry-id
+ Usage: required
+ Value type: <u32>
+ Definition : should be 0,2,4...64. the number of TDM entry.
+
+- fsl,tdm-interface
+ Usage: optional
+ Value type: <empty>
+ Definition : Specify that hdlc is based on tdm-interface
+
+Example:
+
+ ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot = <0xfffffffe>;
+ fsl,rx-timeslot = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-mode = "normal";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
+fsl,siram-entry-id : SI RAM entry ID for the TDM
+fsl,tdm-interface : hdlc is based on tdm-interface
On Wen, Feb 24, 2016 at 04:22AM, Rob Herring wrote:
-----Original Message-----
From: Rob Herring [mailto:robh@kernel.org]
Sent: Wednesday, February 24, 2016 4:22 AM
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: oss@buserror.net; Yang-Leo Li <redacted>; linux-
kernel@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-
dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/7] QE: Add ucc hdlc document to bindings
=20
On Thu, Feb 18, 2016 at 09:06:07AM +0800, Zhao Qiang wrote:
quoted
Add ucc hdlc document to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
=20
Not a very useful description.
Could you give a example for me?
=20
quoted
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- use ucc-hdlc instead of ucc_hdlc
- add more information to properties.
.../bindings/powerpc/fsl/cpm_qe/network.txt | 93
@@ -41,3 +41,96 @@ Example: fsl,mdio-pin =3D <12>; fsl,mdc-pin =3D <13>; };++* HDLC++Currently defined compatibles:+- fsl,ucc-hdlc++Properties for fsl,ucc-hdlc:+- rx-clock-name+- tx-clock-name+ Usage: required+ Value type: <string>+ Definition : should be "brg1"-"brg16" for internal clock source,+ should be "clk1"-"clk28" for external clock source.++- fsl,rx-sync-clock+ Usage: required+ Value type: <string>+ Definition : should be "none" when using internal clock source,+ should be "rsync_pin" when using external clock source.
=20
Why not a boolean property here?
fsl,rx-sync-clock should have other values.
But now we just use rsync_pin and none.
quoted
+
+- fsl,tx-timeslot
+- fsl,rx-timeslot
=20
Perhaps append "-mask"
Agree, I will modify in next version.
=20
quoted
+ Usage: required
+ Value type: <u32>
+ Definition : time slot for TDM operation. Indicates which time slots
+ used for transmitting and receiving.
+
+- fsl,tdm-framer-type
+ Usage: required
+ Value type: <string>
+ Definition : "e1" or "t1"
=20
Boolean?
We just support e1 and t1, in fact, there are more TDM framer types.
=20
quoted
+
+- fsl,tdm-mode
+ Usage: required
+ Value type: <string>
+ Definition : "normal" or "internal-loopback"
@@ -0,0 +1,19 @@+* Serial++Currently defined compatibles:+- ucc_uart++Properties for ucc_uart:+port-number : port number of UCC-UART+tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,+ should be "clk1"-"clk28" for external clock source.++Example:++ ucc_serial: ucc@2200 {+ device_type = "serial";+ compatible = "ucc_uart";+ port-number = <1>;+ rx-clock-name = "brg2";+ tx-clock-name = "brg2";+ };
@@ -0,0 +1,19 @@+* Serial++Currently defined compatibles:+- ucc_uart++Properties for ucc_uart:+port-number : port number of UCC-UART
How is this used?
+tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
+ should be "clk1"-"clk28" for external clock source.
Perhaps you should be using the clock binding here and in other
bindings?
+
+Example:
+
+ ucc_serial: ucc@2200 {
+ device_type = "serial";
+ compatible = "ucc_uart";
+ port-number = <1>;
+ rx-clock-name = "brg2";
+ tx-clock-name = "brg2";
+ };
--
2.1.0.27.g96db324
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
@@ -0,0 +1,19 @@+* Serial++Currently defined compatibles:+- ucc_uart++Properties for ucc_uart:+port-number : port number of UCC-UART
How is this used?
quoted
+tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
+ should be "clk1"-"clk28" for external clock source.
Perhaps you should be using the clock binding here and in other
bindings?
These properties are required by the underlying UCC binding
(Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt) and predate
the clock binding.
-Scott
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/brg.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/brg.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/brg.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/brg.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/i2c.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/i2c.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/i2c.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/i2c.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/pic.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/pic.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/pic.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/pic.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/usb.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/usb.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/usb.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/usb.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/gpio.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/gpio.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/gpio.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/gpio.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/firmware.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/firmware.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/firmware.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/firmware.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/par_io.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/par_io.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/pincfg.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/pincfg.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/pincfg.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/pincfg.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/ucc.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/ucc.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/usb.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/usb.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/usb.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/usb.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/serial.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/serial.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/serial.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/serial.txtdiff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/uqe_serial.txtsimilarity index 100%rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txtrename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/uqe_serial.txt
--
2.1.0.27.g96db324
From: Rob Herring <robh@kernel.org> Date: 2016-02-23 20:15:26
On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
quoted hunk
Add IC, SI and SIRAM document of QE to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- Add interrupt-controller in Required properties
- delete address-cells and size-cells for qe-si and qe-siram
.../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++
1 file changed, 50 insertions(+)
From: Scott Wood <oss@buserror.net> Date: 2016-02-23 20:20:19
On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
quoted
Add IC, SI and SIRAM document of QE to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- Add interrupt-controller in Required properties
- delete address-cells and size-cells for qe-si and qe-siram
.../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50
++++++++++++++++++++++
1 file changed, 50 insertions(+)
@@ -69,6 +69,56 @@ Example: }; };+* Interrupt Controller (IC)++Required properties:+- compatible : should be "fsl,qe-ic".
quoted
+- compatible : should be "fsl,qe-si".
quoted
+- compatible : should be "fsl,qe-siram".
These compatible strings are all a bit generic and should have SoC
specific compatible strings.
I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it
should be documented even if a more specific compatible is also added.
-Scott
From: Scott Wood <oss@buserror.net> Date: 2016-02-25 03:11:57
On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote:
quoted
-----Original Message-----
From: Scott Wood [mailto:oss@buserror.net]
Sent: Wednesday, February 24, 2016 4:20 AM
To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
Cc: Yang-Leo Li <redacted>; linux-kernel@vger.kernel.org;
devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device
tree
bindings.
On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
quoted
On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
quoted
Add IC, SI and SIRAM document of QE to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- Add interrupt-controller in Required properties
- delete address-cells and size-cells for qe-si and qe-siram
.../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50
++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git
a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
index 4f89302..84052a7 100644
From: Scott Wood <oss@buserror.net> Date: 2016-02-25 05:56:51
On Thu, 2016-02-25 at 05:55 +0000, Qiang Zhao wrote:
On Thu, 2016-02-25 at 11:12 AM, Scott Wood wrote:
quoted
-----Original Message-----
From: Scott Wood [mailto:oss@buserror.net]
Sent: Thursday, February 25, 2016 11:12 AM
To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
Cc: Yang-Leo Li <redacted>; linux-kernel@vger.kernel.org;
devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device
tree
bindings.
On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
quoted
On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote:
quoted
-----Original Message-----
From: Scott Wood [mailto:oss@buserror.net]
Sent: Wednesday, February 24, 2016 4:20 AM
To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
Cc: Yang-Leo Li <redacted>; linux-kernel@vger.kernel.org;
devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to
device tree bindings.
On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
quoted
On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
quoted
Add IC, SI and SIRAM document of QE to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- Add interrupt-controller in Required properties
- delete address-cells and size-cells for qe-si and qe-siram
.../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50
++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git
a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
index 4f89302..84052a7 100644
---
a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.tx+++ t
@@ -69,6 +69,56 @@ Example: }; };+* Interrupt Controller (IC)++Required properties:+- compatible : should be "fsl,qe-ic".
quoted
+- compatible : should be "fsl,qe-si".
quoted
+- compatible : should be "fsl,qe-siram".
These compatible strings are all a bit generic and should have SoC
specific compatible strings.
I don't know about si/siram, but "fsl,qe-ic" has been around since
2008, so it should be documented even if a more specific compatible
is also added.
Agree, and si/siram are also has been around since 2008.
Where? I couldn't find them when grepping.
Sorry, I make a mistake, they have not been in upstream.
quoted
quoted
In addition, I don’t think it is needed to add specific compatible,
because they are the same in qe-supported soc.
How do we know that they are 100% the same?
You mean it will be changed in later version?
That's always a possibility, but even on current chips, what bit of
documentation are you referring to that confirms it's the exact same logic?
-Scott