Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2 messages, 2 authors, 2016-02-17 · open the first message on its own page

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

From: "Martin K. Petersen" <martin.petersen@oracle.com>
Date: 2016-02-17 03:03:42

quoted
quoted
quoted
quoted
"Tyrel" == Tyrel Datwyler [off-list ref] writes:
quoted
Is there some reason you didn't carry the review tag over from this:

http://mid.gmane.org/20160204084459.GW27969@c203.arch.suse.de

?

James
Tyrel> The patch is slightly changed from v1. A define for AIX os type
Tyrel> was added as mentioned in the cover letter v2 changes, and I
Tyrel> moved the defines to the mad_adapter_info_data structure around
Tyrel> the fields they apply.

Johannes: Mind checking this out?

https://patchwork.kernel.org/patch/8276101/

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

From: Johannes Thumshirn <hidden>
Date: 2016-02-17 08:05:41

On Tue, Feb 16, 2016 at 10:03:24PM -0500, Martin K. Petersen wrote:
quoted
quoted
quoted
quoted
quoted
"Tyrel" == Tyrel Datwyler [off-list ref] writes:
quoted
quoted
Is there some reason you didn't carry the review tag over from this:

http://mid.gmane.org/20160204084459.GW27969@c203.arch.suse.de

?

James
Tyrel> The patch is slightly changed from v1. A define for AIX os type
Tyrel> was added as mentioned in the cover letter v2 changes, and I
Tyrel> moved the defines to the mad_adapter_info_data structure around
Tyrel> the fields they apply.

Johannes: Mind checking this out?
I'm sorry I though I already did.

Reviewed-by: Johannes Thumshirn <redacted>
https://patchwork.kernel.org/patch/8276101/

-- 
Martin K. Petersen	Oracle Linux Engineering
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help