Re: [PATCH v3 0/2] Consolidate redundant register/stack access code

From
David Long <hidden>
Date
2016-02-09 20:55:11
Also in
linux-arm-kernel, linux-sh, lkml
Reply to
Ingo Molnar, 2016-02-09
On 02/09/2016 04:45 AM, Ingo Molnar wrote:
* Michael Ellerman [off-list ref] wrote:
quoted
On Tue, 2016-02-09 at 00:38 -0500, David Long wrote:
quoted
From: "David A. Long" <redacted>

Move duplicate and functionally equivalent code for accessing registers
and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into
common kernel files.

I'm sending this out again (with updated distribution list) because v2
just never got pulled in, even though I don't think there were any
outstanding issues.
A big cross arch patch like this would often get taken by Andrew Morton, but
AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for
us :D
The other problem is that the second patch is commingling changes to 6 separate
architectures:

  16 files changed, 106 insertions(+), 343 deletions(-)

that should probably be 6 separate patches. Easier to review, easier to bisect to,
easier to revert, etc.

Thanks,

	Ingo
I see your point but I'm not sure it could have been broken into separate successive patches that would each build for all architectures.

-dl
Thread (8 messages) 8 messages, 3 authors, last reply 2016-02-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help