Re: [PATCH 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h>
From: Joe Perches <joe@perches.com>
Date: 2016-02-07 19:39:42
Also in:
lkml
On Sun, 2016-02-07 at 17:38 +0000, Luis Henriques wrote:
Instead of defining a local version of struct ethhdr use the standard definition from .
trivia:
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/platforms/ps3/gelic_udbg.c b/arch/powerpc/platforms/ps3/gelic_udbg.c
[]
quoted hunk ↗ jump to hunk
@@ -173,8 +169,8 @@ static void gelic_debug_init(void)h_eth = (struct ethhdr *)dbg.pkt; - memset(&h_eth->dest, 0xff, 6); - memcpy(&h_eth->src, &mac, 6); + memset(&h_eth->h_dest, 0xff, 6); + memcpy(&h_eth->h_source, &mac, 6);
Be nice to use ETH_ALEN and eth_broadcast_addr. Maybe ether_addr_copy too.
quoted hunk ↗ jump to hunk
@@ -183,7 +179,7 @@ static void gelic_debug_init(void)GELIC_LV1_VLAN_TX_ETHERNET_0, 0, 0, &vlan_id, &v2); if (!result) { - h_eth->type = 0x8100; + h_eth->h_proto= 0x8100;
ETH_P_8021Q
quoted hunk ↗ jump to hunk
header_size += sizeof(struct vlantag); h_vlan = (struct vlantag *)(h_eth + 1);@@ -191,7 +187,7 @@ static void gelic_debug_init(void)h_vlan->subtype = 0x0800; h_ip = (struct iphdr *)(h_vlan + 1); } else { - h_eth->type = 0x0800; + h_eth->h_proto= 0x0800;
ETH_P_IP