Re: [PATCH v7 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2016-01-28 08:40:48
Also in:
linux-api, linux-pm, lkml
On 28-01-16, 12:55, Shilpasri G Bhat wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu index b683e8e..dea4620 100644 --- a/Documentation/ABI/testing/sysfs-devices-system-cpu +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu@@ -271,3 +271,48 @@ Description: Parameters for the CPU cache attributes - WriteBack: data is written only to the cache line and the modified cache line is written to main memory only when it is replaced + +What: /sys/devices/system/cpu/cpufreq/chip*/throttle_stats
What about the chip directory ? Shouldn't that be documented? And shouldn't that mention that this is just for powerpc ? And before that, I don't think that you are doing this properly. I am sorry that I never came to a point where I could review it, and you continued with it, version after version. But, I really have strong objections to the way this is done. And you are making things more complex then they are. So, these stats are per-policy, right ? Then why aren't they added on the policy->kobj instead, just like cpufreq-stats? And maybe inside cpufreq-stats folder only? That will solve many complexities you have in place here and will look sane as well. Right now, you have stats as two places, cpu/cpufreq/chip/ and cpu/cpuX/cpufreq/stats/, which doesn't look wise and adds to confusion. What do you say? -- viresh