RE: [PATCH] powerpc: fsl: update fman dt binding for PCS PHY

Subject: Re: [PATCH] powerpc: fsl: update fman dt binding for PCS PHY
=20
On Mon, Dec 28, 2015 at 11:47:34AM +0800, shh.xie@gmail.com wrote:

quoted

From: Shaohui Xie <redacted>

PCS PHY can support backplane (1000BASE-KX and 10GBASE-KR), this needs
to change corresponding serdes lane settings, so a reference is needed
for serdes lane. This patch describes properties needed for PCS PHY to
support backplane.

Signed-off-by: Shaohui Xie <redacted>
---
based on: http://patchwork.ozlabs.org/patch/560936/

 Documentation/devicetree/bindings/powerpc/fsl/fman.txt | 14
++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt

b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
index 55c2c03..b38e727 100644

--- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt

@@ -432,6 +432,16 @@ example of how to define a PHY (Internal PHY has n=

o

interrupt line).

quoted

 - For "fsl,fman-mdio" compatible internal mdio bus, the PHY is TBI PHY=

.

quoted

 - For "fsl,fman-memac-mdio" compatible internal mdio bus, the PHY is P=

CS PHY,

quoted

   PCS PHY addr must be '0'.
+  PCS PHY can support backplane (1000BASE-KX and 10GBASE-KR), this
+ needs to  change the corresponding serdes lane settings.
+
+  PCS PHY node properties required for backplane:
+
+  - compatible: must be "ethernet-phy-ieee802.3-c45".
+  - phy-mode: string, operation mode of the PHY interface; must be "10=

00base-

kx"

quoted

+    for 1000BASE-KX, or "10gbase-kr" for 10GBASE-KR.

=20
Seems like these should be in common ethernet phy binding.

[S.H] 'compatible' and 'phy-mode' are standard properties already in common=
 Ethernet
phy binding, I can update 'phy-mode' with "1000base-kx" and "10gbase-kr", h=
ow
about I still list the two properties here for the requirement of PCS PHY t=
o support
backplane?

=20

quoted

+  - lane-handle: phandle, specifies a reference to a node representing=

 a

Serdes.

quoted

+  - lane-range: offset and length of the register set for the serdes l=

ane.

=20
These seem pretty FSL specific, so add vendor prefix.

[S.H] OK. will add fsl prefix.

Thank you for reviewing the patch!

Shaohui