Re: [PATCH v4 8/9] Implement kernel live patching for ppc64le (ABIv2)
From: Torsten Duwe <hidden>
Date: 2015-12-04 09:06:27
Also in:
lkml
From: Torsten Duwe <hidden>
Date: 2015-12-04 09:06:27
Also in:
lkml
On Thu, Dec 03, 2015 at 05:24:45PM +0100, Petr Mladek wrote:
quoted
+++ b/arch/powerpc/include/asm/livepatch.h@@ -0,0 +1,45 @@[...]quoted
+#include <linux/module.h> +#include <linux/ftrace.h> + +#ifdef CONFIG_LIVEPATCH +static inline int klp_check_compiler_support(void) +{ +#if !defined(_CALL_ELF) || _CALL_ELF != 2I am just curious why we do not check CC_USING_MPROFILE_KERNEL like in the other similar locations. It would look less cryptic. But I am not sure if it is precise enough.
Because a ppc with a gcc > 4.8.5 is not sufficient. The code currently only works for the PPC ELF ABI v2, a.k.a. ppc64le. But now that you say it, CC_USING_MPROFILE_KERNEL should go into that condition as well. Thanks! Torsten