Thread (51 messages) 51 messages, 4 authors, 2015-11-27

Re: [PATCH V5 30/31] powerpc/mm: Move THP headers around

From: Aneesh Kumar K.V <hidden>
Date: 2015-11-24 11:20:52

Denis Kirjanov [off-list ref] writes:
On 11/23/15, Aneesh Kumar K.V [off-list ref] wrote:
quoted
We support THP only with book3s_64 and 64K page size. Move
THP details to hash64-64k.h to clarify the same.
...
quoted
-static inline void hpte_do_hugepage_flush(struct mm_struct *mm,
-					  unsigned long addr, pmd_t *pmdp,
-					  unsigned long old_pmd)
-{
-
-	WARN(1, "%s called with THP disabled\n", __func__);
We can't reach this function with huge pages disabled, right?
Would it be better to use WARN_ON_ONCE?
Shouldn't matter, if should never get called and if we get called, them
something is really wrong, and mostly need a kernel fix. This will only
happen during devel mistakes.

-aneesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help