Thread (4 messages) flat view 4 messages, 2 authors, 2015-11-10

Re: [PATCH] of: Print rather than WARN'ing when overlap check fails

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2015-11-10 21:47:06
Also in: linux-devicetree, lkml

On Tue, 2015-11-10 at 09:41 +0000, David Laight wrote:
From: Michael Ellerman
quoted
Sent: 10 November 2015 05:09
__rmem_check_for_overlap() is called very early in boot, and on some
powerpc systems it's not safe to call WARN that early in boot.

If the overlap check fails the system will oops instead of printing a
warning. Furthermore because it's so early in boot the console is not up
and the user doesn't see the oops, they just get a dead system.
Wouldn't it be better to add the required checks to WARN()?
Yes obviously it would. But that's less simple than it sounds. I'm working on
it.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help