Thread (50 messages) 50 messages, 5 authors, 2015-11-02

Re: [PATCH V10 01/12] PCI/IOV: Rename and export virtfn_add/virtfn_remove

From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2015-10-27 23:07:02
Also in: linux-pci

On Mon, Oct 26, 2015 at 11:15:51AM +0800, Wei Yang wrote:
During EEH recovery, hotplug is applied to the devices which don't
have drivers or their drivers don't support EEH. However, the hotplug,
which was implemented based on PCI bus, can't be applied to VF directly.

The patch renames virtn_{add,remove}() and exports them so that they
can be used in PCI hotplug during EEH recovery.
Trivial, but write this as an imperative sentence, e.g.,

  Rename virtn_{add,remove}() and export them so they
  can be used in PCI hotplug during EEH recovery.

"The patch" doesn't add any useful information; it's obvious that the
changelog applied to this patch.

This comment also applies to at least the next patch.

Bjorn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help