Thread (38 messages) 38 messages, 3 authors, 2015-10-13

Re: [PATCH v3 10/31] powerpc/mm: Don't use pmd_val,pud_val and pgd_val as lvalue

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2015-10-13 05:10:07

On Tue, 2015-10-13 at 00:09 +0530, Aneesh Kumar K.V wrote:
We convert them static inline function here as we did with pte_val in
the previous patch
This breaks ppc40x_defconfig & 40x/ep405_defconfig with:

  arch/powerpc/mm/40x_mmu.c: In function 'mmu_mapin_ram':
  arch/powerpc/mm/40x_mmu.c:113:20: error: lvalue required as left operand of assignment
  arch/powerpc/mm/40x_mmu.c:114:20: error: lvalue required as left operand of assignment
  arch/powerpc/mm/40x_mmu.c:115:20: error: lvalue required as left operand of assignment
  arch/powerpc/mm/40x_mmu.c:116:20: error: lvalue required as left operand of assignment
  arch/powerpc/mm/40x_mmu.c:128:18: error: lvalue required as left operand of assignment

Which is mainly:

	pmd_val(*pmdp++) = val;


The obvious patch to use pmd_set() doesn't work, I think because there's no
pmd_set() defined for 32-bit nohash?

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help