On Fri, Oct 02, 2015 at 06:58:09PM +1000, Alexey Kardashevskiy wrote:

On 08/19/2015 12:01 PM, Wei Yang wrote:

quoted

The alignment of IOV BAR on PowerNV platform is the total size of the IOV
BAR. No matter whether the IOV BAR is extended with number of
roundup_pow_of_two(total_vfs) or number of max PE number (256), the total
size could be calculated by (vfs_expanded * VF_BAR_size).

This patch simplifies the pnv_pci_iov_resource_alignment() by removing the
first case.

Signed-off-by: Wei Yang <redacted>
Reviewed-by: Gavin Shan <redacted>
---
 arch/powerpc/platforms/powernv/pci-ioda.c |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
index 8c031b5..e3e0acb 100644
--- a/arch/powerpc/platforms/powernv/pci-ioda.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda.c

@@ -2988,12 +2988,16 @@ static resource_size_t pnv_pci_iov_resource_alignment(struct pci_dev *pdev,
 						      int resno)
 {
 	struct pci_dn *pdn = pci_get_pdn(pdev);
-	resource_size_t align, iov_align;
-
-	iov_align = resource_size(&pdev->resource[resno]);
-	if (iov_align)
-		return iov_align;
+	resource_size_t align;

+	/*
+	 * On PowerNV platform, IOV BAR is mapped by M64 BAR to enable the
+	 * SR-IOV. While from hardware perspective, the range mapped by M64
+	 * BAR should be size aligned.

Out of curiosity - IOV BAR does NOT have to be aligned on other platforms?

Quick answer, NO. On other platforms, the alignment applies to VF BAR size.

IOV BAR is composed with several VF BAR. 
    
    IOV BAR size = VF BAR size * total_vfs

And usually VF BAR size equals to one of the PF's BAR size. According to the
SPEC, IOV BAR should be VF BAR size aligned, instead of the IOV BAR size
aligned. This requirement is implicitly met, since PF's BAR alignment is took
into consideration.

The IOV BAR alignment is based on M64 BAR on powernv.

quoted

+	 *
+	 * This function returns the total IOV BAR size if expanded or just the
+	 * individual size if not.

Expanded vs. non-expanded means "using shared M64" (when it is split by 256
segments) vs. "using entire M64"?

Yes, you are right.

When we use "shared M64", IOV BAR should be aligned by its total size. Then we
need to return the total size.

When we use "entire M64", IOV BAR just need to be aligned with VF BAR size.
That's why just return individual size.

quoted

+	 */
 	align = pci_iov_resource_size(pdev, resno);
 	if (pdn->vfs_expanded)
 		return pdn->vfs_expanded * align;

-- 
Alexey

-- 
Richard Yang
Help you, Help me