On Fri, 2015-10-23 at 02:49 -0500, Zhao Qiang-B45475 wrote:

On Fri, Oct 23, 2015 at 11:20 AM, Wood Scott-B07421 <scottwood@freescale.com

quoted

wrote:
-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, October 23, 2015 11:20 AM
To: Zhao Qiang-B45475 <redacted>
Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
lauraa@codeaurora.org; Xie Xiaobo-R63061 [off-list ref];
benh@kernel.crashing.org; Li Yang-Leo-R58472 [off-list ref];
paulus@samba.org
Subject: Re: [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc

On Wed, Oct 14, 2015 at 03:16:08PM +0800, Zhao Qiang wrote:

quoted

diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig

b/drivers/soc/fsl/qe/Kconfig similarity index 50% copy from
arch/powerpc/sysdev/qe_lib/Kconfig
copy to drivers/soc/fsl/qe/Kconfig
index 3c25199..283fe0d 100644

--- a/arch/powerpc/sysdev/qe_lib/Kconfig
+++ b/drivers/soc/fsl/qe/Kconfig

@@ -2,6 +2,17 @@
 # QE Communication options
 #

+config QUICC_ENGINE
+ bool "Freescale QUICC Engine (QE) Support"
+ depends on FSL_SOC && PPC32
+ select GENERIC_ALLOCATOR
+ select CRC32
+ help
+   The QUICC Engine (QE) is a new generation of communications
+   coprocessors on Freescale embedded CPUs (akin to CPM in older

chips).

quoted

+   Selecting this option means that you wish to build a kernel
+   for a machine with a QE coprocessor.
+
 config UCC_SLOW
  bool
  default y if SERIAL_QE

@@ -19,9 +30,3 @@ config UCC_FAST
 config UCC
  bool
  default y if UCC_FAST || UCC_SLOW
-
-config QE_USB
- bool
- default y if USB_FSL_QE
- help
-   QE USB Controller support

Why did some config symbols get moved and others not?

Because QE_USB should be putted under drivers/usb,
It is independent of this patchset.

If it's independent of this patchset then don't put it in this patchset.  
Move all the QE stuff to drivers/soc and then later if something belongs 
somewhere else, have a separate patch move it there.

-Scott