Thread (5 messages) 5 messages, 2 authors, 2015-10-06

[PATCH] powerpc: Kconfig.cputype: Disallow TUNE_CELL on LE systems

flat view
STALE4026d

From: Thomas Huth <hidden>
Date: 2015-09-18 14:17:06
Subsystem: linux for powerpc (32-bit and 64-bit), the rest · Maintainers: Madhavan Srinivasan, Linus Torvalds

It looks somewhat weird that you can enable TUNE_CELL on little
endian systems, so let's disable this option with CPU_LITTLE_ENDIAN.

Signed-off-by: Thomas Huth <redacted>
---
 I first thought that it might be better to make this option depend
 on PPC_CELL instead ... but I guess it's a bad idea to depend a
 CPU option on a platform option? Alternatively, would it make
 sense to make it depend on (GENERIC_CPU || CELL_CPU) instead?

 arch/powerpc/platforms/Kconfig.cputype | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
index c140e94..d93e131 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -149,7 +149,7 @@ config 6xx
 
 config TUNE_CELL
 	bool "Optimize for Cell Broadband Engine"
-	depends on PPC64 && PPC_BOOK3S
+	depends on PPC64 && PPC_BOOK3S && !CPU_LITTLE_ENDIAN
 	help
 	  Cause the compiler to optimize for the PPE of the Cell Broadband
 	  Engine. This will make the code run considerably faster on Cell
-- 
1.8.3.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help