Thread (19 messages) 19 messages, 3 authors, 2015-10-07

Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

From: Alexander Popov <hidden>
Date: 2015-09-29 06:30:54
Also in: linux-devicetree, lkml

On 28.09.2015 16:18, Timur Tabi wrote:
Alexander Popov wrote:
quoted
The only question I have: why calling dma_unmap_single() from within
a spinlock is a bad practice?
I don't know, but usually functions that allocate or free memory cannot be
called from within a spinlock.  You need to check that.  Since the MPC5121
is a single-core CPU, you might not notice if you're doing something wrong.
I've double-checked the code and LDD and don't see any reason to avoid
calling dma_unmap_single() from interrupt context and within spinlock.

Please correct me if I'm wrong.
Thanks.

Best regards,
Alexander
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help