Thread (3 messages) 3 messages, 2 authors, 2015-09-17

Re: [PATCH] arch-powerpc: Return false instead of -EFAULT

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2015-09-17 09:47:37
Also in: lkml

On Thu, 2015-09-17 at 11:18 +0200, Peter Senna Tschudin wrote:
Returning a negative value for a boolean function seem to have the
undesired effect of returning true. Replace -EINVAL by false in a
bool-returning function.

The diff of the .s file before and after the change (using cross
compilation) starts with:

440,441c440,441
< .L43:
< 	li 3,1	 # D.25775,
---
quoted
.L42:
	li 3,0	 # D.25775,
...

while if -EFAULT is replaced by true, the diff is empty.
Ah, that's rather unfortunate.

Can you post the full asm listing, for all three cases?

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help