Thread (12 messages) flat view 12 messages, 3 authors, 2015-08-17

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

From: Christoph Hellwig <hch@lst.de>
Date: 2015-08-15 09:19:53
Also in: linux-fsdevel, lkml, nvdimm

On Thu, Aug 13, 2015 at 10:51:11AM -0600, Ross Zwisler wrote:
Update the annotation for the kaddr pointer returned by direct_access()
so that it is a __pmem pointer.  This is consistent with the PMEM driver
and with how this direct_access() pointer is used in the DAX code.
IFF we stick to the __pmem annotations this looks good.

That beeing said I start to really dislike them.  We don't special
accesors to read/write from pmem, we just need to explicitly commit
it if we want to make it persistent.  So I really don't see the need
to treat it special and require all the force casts to and from the
attribute.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help