RE: [PATCH] video/fsl: Fix the sleep function for FSL DIU module

Hi Tabi,

-----Original Message-----
From: Timur Tabi [mailto:timur@tabi.org]
Sent: Tuesday, March 25, 2014 11:55 PM
To: Wang Dongsheng-B40534
Cc: Wood Scott-B07421; Jin Zhengxiong-R64188; Li Yang-Leo-R58472; linuxpp=

c-

dev@lists.ozlabs.org; linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video/fsl: Fix the sleep function for FSL DIU module
=20
On 03/25/2014 02:56 AM, Dongsheng Wang wrote:

quoted

From: Jason Jin <redacted>

For deep sleep, the diu module will power off, when wake up from the
deep sleep, the registers need to be reinitialized.

Signed-off-by: Jason Jin <redacted>
Signed-off-by: Wang Dongsheng <redacted>

diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
index e8758b9..7ec780c 100644
--- a/drivers/video/fsl-diu-fb.c
+++ b/drivers/video/fsl-diu-fb.c

@@ -1628,9 +1628,18 @@ static int fsl_diu_suspend(struct platform_devic=

e

*ofdev, pm_message_t state)

quoted

  static int fsl_diu_resume(struct platform_device *ofdev)
  {
  	struct fsl_diu_data *data;
+	struct mfb_info *mfbi;

=20
You don't need this, if ...
=20

quoted

+	int i;

  	data =3D dev_get_drvdata(&ofdev->dev);
-	enable_lcdc(data->fsl_diu_info);
+	fsl_diu_enable_interrupts(data);
+	update_lcdc(data->fsl_diu_info);
+
+	for (i =3D 0; i < NUM_AOIS; i++) {
+		mfbi =3D &data->mfb[i];
+		if (mfbi->count)

=20
... you do this:
=20
		if (data->mfb[i].count)
=20
Also, 'i' should be an 'unsigned int'.
=20

quoted

+			fsl_diu_enable_panel(&data->fsl_diu_info[i]);
+	}

  	return 0;
  }

=20
Other than that, this seems okay.
=20

Thanks, send v2 to update this patch.

Regards,
-Dongsheng