Re: [PATCH 4/4] cxl: sparse: Silence iomem warning in debugfs file creation
From: Michael Neuling <hidden>
Date: 2015-08-07 04:13:13
On Fri, 2015-08-07 at 13:18 +1000, Daniel Axtens wrote:
An IO address, tagged with __iomem, is passed to debugfs_create_file as private data. This requires that it be cast to void *. The cast creates a sparse warning: /scratch/dja/linux-capi/drivers/misc/cxl/debugfs.c:51:57: warning: cast r=
emoves address space of expression
=20 The address space marker is added back in the file operations (fops_io_u64). =20 Silence the warning with __force. =20 Signed-off-by: Daniel Axtens <redacted>
Acked-by: Michael Neuling <redacted>
quoted hunk ↗ jump to hunk
--- drivers/misc/cxl/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) =20diff --git a/drivers/misc/cxl/debugfs.c b/drivers/misc/cxl/debugfs.c index 825c412580bc..18df6f44af2a 100644 --- a/drivers/misc/cxl/debugfs.c +++ b/drivers/misc/cxl/debugfs.c@@ -48,7 +48,7 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_io_x64, debugfs_io_u64_get=
, debugfs_io_u64_set, "0x
static struct dentry *debugfs_create_io_x64(const char *name, umode_t mo=
de,
struct dentry *parent, u64 __iomem *value)
{
- return debugfs_create_file(name, mode, parent, (void *)value, &fops_io_=x64);
+ return debugfs_create_file(name, mode, parent, (void __force *)value, &=
fops_io_x64);
} =20 int cxl_debugfs_adapter_add(struct cxl *adapter)