On Fri, 2015-08-28 at 08:40 +0800, Scott Wood wrote:

On Thu, Aug 27, 2015 at 4:35 AM, Scott Wood [off-list ref] 
wrote:

quoted

On Wed, Aug 26, 2015 at 08:09:45PM +0800, Chenhui Zhao wrote:

I didn't write this e-mail.  Please fix your mail client.

quoted

quoted

 +static void rcpm_v1_cpu_up_prepare(int cpu)
 +{
 +        rcpm_v1_cpu_exit_state(cpu, E500_PM_PH15);
 +        rcpm_v1_irq_unmask(cpu);
 +}
 +
 +static void rcpm_v2_cpu_exit_state(int cpu, int state)
 +{
 +        int hw_cpu = get_hard_smp_processor_id(cpu);
 +        u32 mask = 1 << cpu_core_index_of_thread(hw_cpu);

Are you sure cpu_core_index_of_thread() is supposed to take a hardware
cpu id?  The only current user, pseries_energy.c, has the comment
"Convert logical cpu number to core number".

Here, the method of getting core index of thread is same for physical 
and logical.
So use this existed function to do the job.

I realize that you get the same result either way, but that doesn't make it 
OK.  You have "cpu"; pass that instead of "hw_cpu".

-Scott