Re: [PATCH 2/5] dma-mapping: consolidate dma_{alloc, free}_noncoherent
From: Russell King - ARM Linux <hidden>
Date: 2015-08-13 15:21:17
Also in:
linux-alpha, linux-mips, linux-s390, linux-sh, lkml, sparclinux
On Thu, Aug 13, 2015 at 05:04:05PM +0200, Christoph Hellwig wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h index 2ae3424..ab521d5 100644 --- a/arch/arm/include/asm/dma-mapping.h +++ b/arch/arm/include/asm/dma-mapping.h@@ -175,21 +175,6 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) return dma_addr == DMA_ERROR_CODE; } -/* - * Dummy noncoherent implementation. We don't provide a dma_cache_sync - * function so drivers using this API are highlighted with build warnings. - */
I'd like a similar comment to remain after this patch explaining that we don't support non-coherent allocations and that it'll be highlighted by the lack of dma_cache_sync, otherwise I'm sure we'll start to get patches to add the thing. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.