Thread (2 messages) 2 messages, 2 authors, 2015-08-07

Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing

From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2015-08-07 10:17:56
Also in: kvm, lkml


On 06/08/2015 19:13, Nicholas Krause wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c
index 6249cdc..5a18859 100644
--- a/arch/powerpc/kvm/mpic.c
+++ b/arch/powerpc/kvm/mpic.c
@@ -1641,13 +1641,16 @@ static void mpic_destroy(struct kvm_device *dev)
 static int mpic_set_default_irq_routing(struct openpic *opp)
 {
 	struct kvm_irq_routing_entry *routing;
+	int ret;
 
 	/* Create a nop default map, so that dereferencing it still works */
 	routing = kzalloc((sizeof(*routing)), GFP_KERNEL);
 	if (!routing)
 		return -ENOMEM;
 
-	kvm_set_irq_routing(opp->kvm, routing, 0, 0);
+	ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0);
+	if (ret)
+		return ret;
 
 	kfree(routing);
 	return 0;
The patch leaks the "routing" variable if you hit the error path.

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help