Thread (58 messages) 58 messages, 5 authors, 2015-08-20

Re: [PATCH v5 07/46] usb: dwc3: gadget: add ep capabilities support

From: Felipe Balbi <hidden>
Date: 2015-08-04 16:10:39
Also in: linux-arm-kernel, linux-omap, lkml

On Fri, Jul 31, 2015 at 04:00:19PM +0200, Robert Baldyga wrote:
quoted hunk ↗ jump to hunk
Convert endpoint configuration to new capabilities model.

Signed-off-by: Robert Baldyga <redacted>
---
 drivers/usb/dwc3/gadget.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 2feed9e..bd4c3db 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1715,6 +1715,19 @@ static int dwc3_gadget_init_hw_endpoints(struct dwc3 *dwc,
 				return ret;
 		}
 
+		if (epnum == 0 || epnum == 1) {
+			dep->endpoint.caps.type_control = true;
+		} else {
+			dep->endpoint.caps.type_iso = true;
+			dep->endpoint.caps.type_bulk = true;
+			dep->endpoint.caps.type_int = true;
+		}
+
+		if (direction)
+			dep->endpoint.caps.dir_in = true;
+		else
+			dep->endpoint.caps.dir_out = true;
you can avoid the branch for the direction:

		dep->endpoint.caps.dir_in = !!direction;
		dep->endpoint.caps.dir_out = !direction;

-- 
balbi

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help