Re: [PATCH] spi: mpc512x-psc: add support for Freescale MPC5125

On Wed, Jul 15, 2015 at 09:40:19AM +0200, Uwe Kleine-König wrote:

On Tue, Jul 14, 2015 at 10:54:42AM +0100, Mark Brown wrote:

quoted

quoted

 static const struct of_device_id mpc512x_psc_spi_of_match[] = {
-	{ .compatible = "fsl,mpc5121-psc-spi", },
+	{ .compatible = "fsl,mpc5121-psc-spi", .data = (void *)TYPE_MPC5121 },
+	{ .compatible = "fsl,mpc5125-psc-spi", .data = (void *)TYPE_MPC5125 },
 	{},

quoted

The code seems fine but this should update the binding document to
include the new compatible string.

I don't find fsl,mpc5121-psc-spi documented either. The best I found is
ocumentation/devicetree/bindings/powerpc/fsl/mpc5121-psc.txt which
describes fsl,mpc5121-psc-uart and fsl,mpc5121-psc.

OK, then please add a basic binding document.  The point is that new
bindings should be being documented, if people have been lax on this in
the past that does involve a bit of cleanup.