Thread (21 messages) 21 messages, 8 authors, 2015-07-31

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

From: Julien Grall <hidden>
Date: 2015-07-29 11:28:04
Also in: linux-arm-kernel, linux-fbdev, linux-input, linux-scsi, lkml, netdev

Hi Chris,

On 28/07/15 20:39, Chris (Christopher) Brand wrote:
quoted
Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant,
I suspect this is because the first support for Xen was for PV. This brough some
Typo : "brought"
Perhaps "resulted in" would be better ?
quoted
misimplementation of helpers on ARM and make the developper confused the expected behavior.
Typo: "developer".
I'd also suggest "...and confused developers about the...".

[...]
quoted
For clarity and avoid new confusion, replace any reference of mfn into gnf in any helpers used by PV drivers.
Typo : "gfn"
I'd suggest "...replace any reference to mfn with gfn..."

[...]
Thanks for telling me the typoes. I will fix it in the next version of
this series.

Regards,

-- 
Julien Grall
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help