From: Madalin-Cristian Bucur <redacted>
Date: Fri, 24 Jul 2015 15:49:39 +0000

quoted

-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote:

quoted

Allow the user to tweak the refill threshold and the total number
of buffers in the buffer pool. The provided values are for one CPU.

Any value in making these module parameters instead?

I expect one would (hardly ever) change these to improve some corner
cases then use them with the new values. It may help in the tuning process
but afterwards the bloat to the bootcmd would probably be  a nuisance.

I think these should be controlled by the existing ethtool infrastructure.

Neither the Kconfig mechanism nor module parameters are appropriate, at all.