Re: [PATCH v5 1/2] perf,kvm/ppc: Add kvm_perf.h for powerpc
From: Scott Wood <hidden>
Date: 2015-07-16 20:26:31
Also in:
lkml
On Thu, 2015-07-16 at 21:18 +0530, Hemant Kumar wrote:
quoted hunk ↗ jump to hunk
To analyze the exit events with perf, we need kvm_perf.h to be added in the arch/powerpc directory, where the kvm tracepoints needed to trace the KVM exit events are defined. This patch adds "kvm_perf_book3s.h" to indicate that the tracepoints are book3s specific. Generic "kvm_perf.h" then can just include "kvm_perf_book3s.h". Signed-off-by: Hemant Kumar <redacted> --- Changes: - Not exporting the exit reasons compared to previous patchset (suggested by Paul) arch/powerpc/include/uapi/asm/kvm_perf.h | 6 ++++++ arch/powerpc/include/uapi/asm/kvm_perf_book3s.h | 14 ++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 arch/powerpc/include/uapi/asm/kvm_perf.h create mode 100644 arch/powerpc/include/uapi/asm/kvm_perf_book3s.hdiff --git a/arch/powerpc/include/uapi/asm/kvm_perf.hb/arch/powerpc/include/uapi/asm/kvm_perf.h new file mode 100644 index 0000000..5ed2ff3--- /dev/null +++ b/arch/powerpc/include/uapi/asm/kvm_perf.h@@ -0,0 +1,6 @@ +#ifndef _ASM_POWERPC_KVM_PERF_H +#define _ASM_POWERPC_KVM_PERF_H + +#include <asm/kvm_perf_book3s.h> + +#endifdiff --git a/arch/powerpc/include/uapi/asm/kvm_perf_book3s.hb/arch/powerpc/include/uapi/asm/kvm_perf_book3s.h new file mode 100644 index 0000000..8c8d8c2--- /dev/null +++ b/arch/powerpc/include/uapi/asm/kvm_perf_book3s.h@@ -0,0 +1,14 @@ +#ifndef _ASM_POWERPC_KVM_PERF_BOOK3S_H +#define _ASM_POWERPC_KVM_PERF_BOOK3S_H + +#include <asm/kvm.h> + +#define DECODE_STR_LEN 20 + +#define VCPU_ID "vcpu_id" + +#define KVM_ENTRY_TRACE "kvm_hv:kvm_guest_enter" +#define KVM_EXIT_TRACE "kvm_hv:kvm_guest_exit" +#define KVM_EXIT_REASON "trap" + +#endif /* _ASM_POWERPC_KVM_PERF_BOOK3S_H */
Again, why is book3s stuff being presented via uapi as generic <asm/kvm_perf.h> with generic symbol names? -Scott