Thread (8 messages) 8 messages, 3 authors, 2015-07-02

Re: [PATCH RESEND] Update kernel math-emu code from current glibc soft-fp

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2015-07-01 07:34:21
Also in: linux-alpha, linux-s390, linux-sh, lkml, sparclinux

On Wed, Jul 1, 2015 at 12:18 AM, Michael Ellerman [off-list ref] wrote:
On Tue, 2015-06-30 at 10:48 +0000, Joseph Myers wrote:
quoted
On Tue, 30 Jun 2015, Michael Ellerman wrote:
quoted
Is there some way you can imagine of splitting this up into smaller chunks, so
that different arches can merge the pieces separately?
Well, it could be split as:

1. Rename include/math-emu to math-emu-old and update architectures for
the renaming (mechanically).

2. Add new include/math-emu.

3,4,5,6,7. Move each architecture from math-emu-old to math-emu.

8. Remove math-emu-old.

You still have patch 1 affecting all five architectures, but with the
per-architecture changes being much simpler.
OK. That's obviously a bit more churn, but I think it's probably the best
approach. Unless someone else has a better idea?
Does it make that much of a difference?

You said:
| However in it's current form it's not easily mergeable, because it
touches five
| architectures and has the potential to cause breakage on all of them.

Patch 1 still touches five architectures.
Patches 3-7 still have the potential to break an architecture, but only one of
them at a time.
From a bisectability point of view there's no change.
Except that patch 1 (and 8) may break something, too ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help