Thread (4 messages) 4 messages, 3 authors, 2015-06-28

Re: [v2,8/9] fsl/fman: Add FMan Port Support

From: Paul Bolle <hidden>
Date: 2015-06-25 23:28:54
Also in: netdev

On Wed, 2015-06-24 at 22:37 +0300, igal.liberman@freescale.com wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/net/ethernet/freescale/fman/fm_drv.c
+++ b/drivers/net/ethernet/freescale/fman/fm_drv.c
+struct fm_port_t *fm_port_drv_handle(const struct fm_port_drv_t *port)
+{
+	return port->fm_port;
+}
+EXPORT_SYMBOL(fm_port_drv_handle);
I couldn't find any users of this function.
+void fm_port_get_buff_layout_ext_params(struct fm_port_drv_t *port,
+> 	> 	> 	> 	> 	struct fm_port_params *params)
(Evolution 3.16 is a piece of ...).
+{
+	params->data_align = 0;
+}
+EXPORT_SYMBOL(fm_port_get_buff_layout_ext_params);
Ditto.
+int fm_get_tx_port_channel(struct fm_port_drv_t *port)
+{
+	return port->tx_ch;
+}
+EXPORT_SYMBOL(fm_get_tx_port_channel);
Ditto.
quoted hunk ↗ jump to hunk
--- /dev/null
+++ b/drivers/net/ethernet/freescale/fman/fm_port_drv.c
+void fm_set_rx_port_params(struct fm_port_drv_t *port,
+			   struct fm_port_params *params)
+{
+	[...]
+}
+EXPORT_SYMBOL(fm_set_rx_port_params);
Ditto.

(If you hear about my arrest for randomly attacking innocent people:
blame evolution 3.16!)
+void fm_set_tx_port_params(struct fm_port_drv_t *port,
+			   struct fm_port_params *params)
+{
+	[...]
+}
+EXPORT_SYMBOL(fm_set_tx_port_params);
Ditto.
quoted hunk ↗ jump to hunk
--- /dev/null
+++ b/drivers/net/ethernet/freescale/fman/port/fm_port.c
+u64 *fm_port_get_buffer_time_stamp(const struct fm_port_t *p_fm_port,
+				   char *p_data)
+{
+	[...]
+}
+EXPORT_SYMBOL(fm_port_get_buffer_time_stamp);
Ditto.
+int fm_port_disable(struct fm_port_t *p_fm_port)
+{
+	[...]
+}
+EXPORT_SYMBOL(fm_port_disable);
This exports a function that I think is only used inside this file.
+int fm_port_enable(struct fm_port_t *p_fm_port)
+{
+	[...]
+}
+EXPORT_SYMBOL(fm_port_enable);
And here I could again find no users of this function.

Thanks,


Paul Bolle
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help