Thread (45 messages) 45 messages, 3 authors, 2015-06-16

Re: [PATCH V7 03/10] powerpc/pci: Remove VFs prior to PF

From: Bjorn Helgaas <bhelgaas@google.com>
Date: 2015-06-01 23:20:11
Also in: linux-pci

On Tue, May 19, 2015 at 06:50:05PM +0800, Wei Yang wrote:
As commit ac205b7b ("PCI: make sriov work with hotplug remove") indicates,
The conventional reference is:

  ac205b7bb72f ("PCI: make sriov work with hotplug remove")
quoted hunk ↗ jump to hunk
VFs, which might be hooked to same PCI bus as their PF should be removed
before the PF. Otherwise, the PCI hot unplugging on the PCI bus would
cause kernel crash.

The patch applies the above pattern to PowerPC PCI hotplug path.

[gwshan: changelog]
Signed-off-by: Wei Yang <redacted>
Acked-by: Gavin Shan <redacted>
---
 arch/powerpc/kernel/pci-hotplug.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/pci-hotplug.c b/arch/powerpc/kernel/pci-hotplug.c
index 7ed85a6..98f84ed 100644
--- a/arch/powerpc/kernel/pci-hotplug.c
+++ b/arch/powerpc/kernel/pci-hotplug.c
@@ -50,7 +50,7 @@ void pcibios_remove_pci_devices(struct pci_bus *bus)
 
 	pr_debug("PCI: Removing devices on bus %04x:%02x\n",
 		 pci_domain_nr(bus),  bus->number);
-	list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list) {
+	list_for_each_entry_safe_reverse(dev, tmp, &bus->devices, bus_list) {
 		pr_debug("   Removing %s...\n", pci_name(dev));
 		pci_stop_and_remove_bus_device(dev);
 	}
-- 
1.7.9.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help