Thread (3 messages) flat view 3 messages, 2 authors, 2015-06-12

Re: [PATCH v2] powerpc/rcpm: add RCPM driver

From: Paul Bolle <hidden>
Date: 2015-06-12 08:58:06
Also in: linux-devicetree, lkml

Just a nit.

On Thu, 2015-06-11 at 14:32 +0800, Yuantian.Tang@freescale.com wrote:
quoted hunk ↗ jump to hunk
--- /dev/null
+++ b/arch/powerpc/sysdev/fsl_rcpm.c
+int fsl_rcpm_init(void)
This is used only through early_initcall(). I took the cargo cult
approach of looking at the other uses of early_initcall() in
arch/powerpc/. That approach tells me this function could be static and
marked as __init. Would that work here too?
+{
+	[...]
+}
+
+/* need to call this before SMP init */
+early_initcall(fsl_rcpm_init);
Thanks,

Paul Bolle
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help