Re: [PATCH V14 00/14] perf, tools: Add support for PMU events in JSON format
From: Jiri Olsa <hidden>
Date: 2015-06-05 10:29:17
Also in:
lkml
On Thu, Jun 04, 2015 at 11:27:08PM -0700, Sukadev Bhattiprolu wrote: SNIP
- All known events tables for the architecture are included in the perf binary. - For architectures that don't have any JSON files, an empty mapping table is created and they should continue to build) Thanks to input from Andi Kleen, Jiri Olsa, Namhyung Kim and Ingo Molnar. These patches are available from: https://github.com:sukadev/linux.git Branch Description ------------------------------------------------------ json-v14 Source Code only json-files-3 x86 and Powerpc datafiles only json-v14-with-data Both code and data (build/test) NOTE: Only "source code" patches (i.e those in json-v14) are being emailed. Please pull the "data files" from the json-files-3 branch. Changelog[v14] Comments from Jiri Olsa: - Change parameter name/type for pmu_add_cpu_aliases (from void *data to list_head *head) - Use asprintf() in file_name_to_tablename() and simplify/reorg code. - Use __weak definition from <linux/compile.h> - Use fopen() with mode "w" and eliminate unlink() - Remove minor TODO. - Add error check for return value from strdup() in print_pmu_events(). - Move independent changes from patches 3,11,12 .. to separate patches for easier review/backport. - Clarify mapfile's "header line support" in patch description. - Fix build failure with DEBUG=1
all my comments were addressed and apart from 2 small comments, for the patchset: Acked-by: Jiri Olsa <jolsa@kernel.org> thanks, jirka