Thread (34 messages) 34 messages, 5 authors, 2015-06-16

Re: [PATCH v13 03/14] perf, tools: Use pmu_events_map table to create event aliases

From: Jiri Olsa <hidden>
Date: 2015-06-03 10:31:20
Also in: lkml

On Tue, Jun 02, 2015 at 10:12:03AM -0700, Sukadev Bhattiprolu wrote:
At run time, (i.e when perf is starting up), locate the specific events
table for the current CPU and create event aliases for each of the events.

Use these aliases to parse user's specified perf event.

Signed-off-by: Sukadev Bhattiprolu <redacted>

Changelog[v3]
	[Jiri Olsa] Fix a memory leak with cpuid.

Changelog[v2]
	[Andi Kleen] Replace the pmu_events_map->vfm field with a simple
		generic "cpuid" string and use that string to find the
		matching mapfile entry.
---
 tools/perf/arch/powerpc/util/header.c |   11 ++++
 tools/perf/util/header.h              |    3 +-
 tools/perf/util/pmu.c                 |  104 ++++++++++++++++++++++++++++-----
 3 files changed, 104 insertions(+), 14 deletions(-)
I think this patch is doing too much, it should be split into 3 pieces:

  - introduce get_cpuid_str for powerpc
  - introducing __perf_pmu__new_alias/perf_pmu__new_alias functions split
  - adding pmu_add_cpu_aliases functionality

jirka
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help