Re: [PATCH 1/2] powerpc: fix the dependency issue for CRASH_DUMP
From: Scott Wood <hidden>
Date: 2015-05-04 22:17:30
From: Scott Wood <hidden>
Date: 2015-05-04 22:17:30
On Thu, 2015-04-30 at 20:29 +0800, Kevin Hao wrote:
In the current code, the RELOCATABLE will be forcedly enabled when enabling CRASH_DUMP. But for ppc32, the RELOCABLE also depend on ADVANCED_OPTIONS and select NONSTATIC_KERNEL. This will cause build error when CRASH_DUMP=y && ADVANCED_OPTIONS=n. Even there is no such issue for ppc64, but select is only for non-visible symbols and for symbols with no dependencies. As for a symbol like RELOCATABLE, it is definitely not suitable to select it. So choose to depend on it.
Why is it "definitely not suitable to select it", provided the ADVANCED_OPTIONS dependency is removed, and the FLATMEM dependency is moved to places that select RELOCATABLE? It seems wrong that the user should have to enable ADVANCED_OPTIONS to even see the option to build a crash kernel. -Scott