Re: [PATCH 2/2] mmc: sdhci-pltfm: enable interrupt mode to detect card
From: Scott Wood <hidden>
Date: 2015-05-13 16:37:22
Also in:
lkml
On Wed, 2015-05-13 at 16:20 +0800, Yangbo Lu wrote:
quoted hunk ↗ jump to hunk
Enable interrupt mode to detect card instead of polling mode for P1020/P4080/P5020/P5040/T1040 by removing the quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION. This could improve data transferring performance and avoid the call trace caused by polling card status sometime. Signed-off-by: Yangbo Lu <redacted> --- drivers/mmc/host/sdhci-pltfm.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index c5b01d6..62f4049 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c@@ -102,6 +102,13 @@ void sdhci_get_of_property(struct platform_device *pdev) of_device_is_compatible(np, "fsl,mpc8536-esdhc")) host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; + if (of_device_is_compatible(np, "fsl,p5040-esdhc") || + of_device_is_compatible(np, "fsl,p5020-esdhc") || + of_device_is_compatible(np, "fsl,p4080-esdhc") || + of_device_is_compatible(np, "fsl,p1020-esdhc") || + of_device_is_compatible(np, "fsl,t1040-esdhc")) + host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
Please don't line up continuation lines with the if-body. All of the "of_device_is_compatibles" should start in the same column. Given that you need to modify the device tree for this, why not just use SVR? -Scott