Thread (5 messages) 5 messages, 2 authors, 2015-04-09

Re: [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c

From: Ulf Hansson <hidden>
Date: 2015-04-08 09:40:16
Also in: linux-arm-kernel, linux-devicetree, linux-mmc

On 30 March 2015 at 16:46, Suman Tripathi [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch adds some quirks support to be read from fdt.

Signed-off-by: Suman Tripathi <redacted>
---
 drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index bef250e..9f6a4b9 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev)

                if (of_get_property(np, "broken-cd", NULL))
                        host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
+
+               if (of_get_property(np, "delay-after-power", NULL))
+                       host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER;
+
+               if (of_get_property(np, "no-hispd", NULL))
+                       host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
+
+               if (of_get_property(np, "broken-adma", NULL))
+                       host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
+
+               if (of_get_property(np, "broken-dma", NULL))
+                       host->quirks |= SDHCI_QUIRK_BROKEN_DMA;
+
+               if (of_get_property(np, "no-cmd23", NULL))
+                       host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
Can't at least some of these be distinguished from what sdhci variant
that is being used? Instead of having them in DT...

Kind regards
Uffe
                if (of_get_property(np, "no-1-8-v", NULL))
                        host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
--
1.8.2.1

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help